search

ra1u / redis-dart

fast redis protocol parser and client
MIT License
84 stars 35 forks source link

PubSub Subscribe actually using psubscribe #3

Closed rajmaniar closed 9 years ago

rajmaniar commented 9 years ago

I noticed the pubsub.subscribe method is actually sending the redis psubscribe command.

Which is a problem when using the pubsub channels, numsub, etc commands.

ra1u commented 9 years ago

I see , you are correct. I will tray to fix and testcover later today. In meantime you can fix this in https://github.com/ra1u/redis-dart/blob/master/lib/subscriber.dart#L44

rajmaniar commented 9 years ago

Thanks! I changed and tested the psubscribe -> subscribe yesterday and it works perfectly.

-raj

On May 19, 2015 at 11:32:44 PM, Luka Rahne (notifications@github.com) wrote:

I see , you are correct. I will tray to fix and testcover later today. In meantime you can fix this in https://github.com/ra1u/redis-dart/blob/master/lib/subscriber.dart#L44

— Reply to this email directly or view it on GitHub.

ra1u commented 9 years ago

I have uploaded fix on github, but I have some issue uploading package on pub.dartlang.org. I expect resolution in few days.

ra1u commented 9 years ago

fixed in version 0.4.4 or commit https://github.com/ra1u/redis-dart/commit/7c181fd451470e3691d920510e469fc9bd994f18