search

ra1u / redis-dart

fast redis protocol parser and client
MIT License
84 stars 35 forks source link

improve README.md wording and spelling #33

Closed erf closed 3 years ago

erf commented 3 years ago

Improve the README.md for issue #32

Fixed a few spelling errors and improved the language a bit i believe, although i'm not a native english speaker.

Also improved the code syntax by removing the new keyword and using final for variables.

I think however the README could be improved further:

  1. more consistent with using the code and header tags
  2. improve wording even more?
  3. make an async / await example ?

BTW, are you sure the following statement is correct?

We can send all commands without needing to wait for a result, and we can still be sure that the response handled by Future will be completed in the correct order.

Aren't futures arbitrary with regards to when they finish?

Also the statement:

Difference is that there are 5 commands in last examples and only one in the previous example.

The sentence is kind of weird, "last" and "previous" is pretty much the same.

ra1u commented 3 years ago

Thank you for this. English is not my first language. Currently I am not at comp but i will find time in next days.