search

ra1u / redis-dart

fast redis protocol parser and client
MIT License
84 stars 35 forks source link

Consistent lowerCamelCase and send API #36

Closed erf closed 3 years ago

erf commented 3 years ago

I noticed the "send_object" method is not using the lowerCamelCase syntax as recommended here there are also a few other methods using the underscores. Is there a spesific reason for this or would you like to change to this syntax? I would also suggest to rename "send_object" to just "send", and "send_nothing" to just "nothing". I understand this is a breaking change but i you could just bump the major version. What do you think?

I could make these changes..

ra1u commented 3 years ago

Hi erf, thank You for your report.

I agree with you that, we should have methods names consistent with general guidelines. But I am not into making braking change for this minor issue. If this bothers You, we can add alias method and have two same methods with different names.

Regarding name I am more into descriptive names and if you would like to add alias I would prefer sendObject and sendNothing over what you have suggested.

Kind regards, Luka.

erf commented 3 years ago

Ok, i understand.