search

ra3xdh / qucs_s

Qucs-S is a circuit simulation program with Qt-based GUI
https://ra3xdh.github.io/
GNU General Public License v2.0
748 stars 101 forks source link

Fix source components rendering quirks #735

Closed wawuwo closed 3 weeks ago

wawuwo commented 3 weeks ago

Hi!

This a follow-up to #723 and another portion of changes to components to make them look a bit prettier. This time components from "sources" groups were in work.

With this PR also comes a new type of drawing primitive — the so called "Polyline" which allows to draw compound lines consisting of several segments and make good-looking joining of them. I had to add be able to draw nice arrow heads without strange edges etc.

There is a lot of affected components and I was to lazy (shame on me!) to make before/after images this time, but I think a change in component's rendering is something self-describing and easy to see so lack of before/after images shouldn't be a problem.

wawuwo commented 3 weeks ago

Oops, turns out I've confused directions of a couple of arrows. Preparing a --fixup commit…

ra3xdh commented 3 weeks ago

Thanks for the contribution! Merged.