Dark theme and rendering issue on windows

ra3xdh / qucs_s

Qucs-S is a circuit simulation program with Qt-based GUI

https://ra3xdh.github.io/

GNU General Public License v2.0

754 stars 101 forks source link

Dark theme and rendering issue on windows #818

Closed dsm closed 1 day ago

dsm commented 1 week ago

Hi, Qt added new theming for win11 named Windows11 style beginning Qt 6.7. This theme can automatically switch dark and light mode. In dark mode editing component color of the value is white. And some rendering artifact. I add some pictures. @wawuwo

Problem 1:

Problem 2:

Problem 3:

edit from @ra3xdh : Added TODO list

[x] When property value is being edited, value text is misplaced
[x] When property value is being edited and QT theme is switched to dark mode, value text has white color and is barely visible
[x] When property value is being edited, value text is visible only partially
[x] Connections to component ports are rendered incorrectly; if port has only one connection is has to be rendered as a little filled square

ra3xdh commented 1 week ago

I have also recently noticed that the dots on device pins are disappeared after schematic rendering refactoring.

Old
New -- no dots

wawuwo commented 1 week ago

Hi guys!

Here is a checklist of problems to check that I've understood them well and to control the progress. Please correct me if I'm wrong:

[ ] When property value is being edited, value text is misplaced
[ ] When property value is being edited and QT theme is switched to dark mode, value text has white color and is barely visible
[ ] When property value is being edited, value text is visible only partially
[ ] Connections to component ports are rendered incorrectly; if port has only one connection is has to be rendered as a little filled square

dsm commented 1 week ago

The application is already in dark theme, but when the value is changed, there is a white background and white text in windows11, but in macOS, this does not happen in the dark theme, it is white text on a black background. In problem 2, there is also a leftover of the value that normally appears on the white background, which should not be there.

ra3xdh commented 1 week ago

The #820 resolves the problem with nodes rendering. I have added TODO list for this issue.

wawuwo commented 1 week ago

@dsm I made a patch which uses different approach to control colours when property values is being edited, but unfortunately I don't have a windows-based machine to try it out. Could you please try the patch to check if it fixes the problem №2?

UPD: hadn't seen you comment in #828 when I added this comment; I'm glad it works!

dsm commented 1 week ago

Yes this patch fixed Problem 2.

ra3xdh commented 1 day ago

The full fix provided by #842 Closing as completed.