ra3xdh / qucs_s

Qucs-S is a circuit simulation program with Qt-based GUI
https://ra3xdh.github.io/
GNU General Public License v2.0
886 stars 115 forks source link

Matching Circuit Tool generates wrong results #905

Closed tomhajjar closed 3 months ago

tomhajjar commented 3 months ago

Update:

The device seems to be marginally stable. Project updated with all fixes

Follow up to #401, @andresmmera

In testing Matching Circuit Tool for an "L-section match" case, I found the component values to be unrealistic.

The input match L1 shunt inductor value of "0.000H" should be interpreted as a short to ground or possibly using "creative license", an open circuit to ground. The output match L4 series inductor value of "2.556H" can only be interpreted as an open circuit.

I didn't test any other cases since having to copy and paste S-parameter values becomes tedious and error prone.

2024-08-23_184159 2024-08-23_184019 2024-08-23_183704

BFP193W_amplifier_prj.zip

andresmmera commented 3 months ago

Hi @tomhajjar , thanks for pointing this out.

The device is not unconditionally stable and it cannot be conjugately matched. Equations 12.40a/b in [1] don't have a solution for this case since the argument of the square roots is negative.

image

image

I think that the best solution would be to check if the device is unconditionally stable here in order to avoid wrong results like this. I can write a fix for this later.

Schematic: BFP193W_spar_analysis.zip

[1] Microwave Engineering. David M Pozar. 4th Edition. 2012

tomhajjar commented 3 months ago

Not often a device's Spice model correlates so well with it's S-parameter data...

2024-08-24_085742 2024-08-24_085723

tomhajjar commented 3 months ago

@andresmmera

One minor issue with the tool is if any entry or setting is "wrong" or out of bounds, a error message is shown and the tool is closed. Is there a way to allow the user to fix the wrong entry and not close the tool?

andresmmera commented 3 months ago

Good point. I'll take a look later.

ra3xdh commented 3 months ago

Fixed by #907. Closing as completed.

andresmmera commented 3 months ago

@andresmmera

One minor issue with the tool is if any entry or setting is "wrong" or out of bounds, a error message is shown and the tool is closed. Is there a way to allow the user to fix the wrong entry and not close the tool?

Fixed in PR #909

tomhajjar commented 3 months ago

This Qorvo tool is useful for seeing the effect of R on K.

2024-08-25_130123