search

ra3xdh / qucs_s

Qucs-S is a circuit simulation program with Qt-based GUI
https://ra3xdh.github.io/
GNU General Public License v2.0
867 stars 111 forks source link

qucs-s for OSX 10.14 #921

Closed bnilsson11 closed 1 month ago

bnilsson11 commented 1 month ago

In qucs-s 24.3.0 for MacOS 10.14, the Delete command using keyboard Delete or Backspace is not working. Delete using mouse right-click is working.

dsm commented 1 month ago

I'll fix this issue, normally delete shortcut is QKeySequence::Delete but delete button not working for macbook m3 pro so I changed QKeySequence::Delete to QKeySequence::Backspace but in Qt 6.2 Meta+H is QKeySequence::Backspace but Qt 6.7 Meta+H or backspace is QKeySequence::Backspace. So in your mac Meta+H should work it Qt Doc says. but I'll added QKeySequence::Backspace and QKeySequence::Delete both for delete. can you test it ?

bnilsson11 commented 1 month ago

This Mac is at my old work place, and I am there every Monday morning to after lunch time. So it will take a week before I can test it.

dsm commented 1 month ago

Ok I'll add directly backspace and delete key and I don't use QKeySequence and I'll test it both macbook and logi mx keys keybords as soon as I get home.

dsm commented 1 month ago

I pushed a commit that solve this issue, I tested backspace and delete keys both works under mac, some mac keyboards don't have delete key so backspace added for this reason.

ra3xdh commented 1 month ago

Fixed by https://github.com/ra3xdh/qucs_s/commit/13e920915358bb7b56ff30f1fc6917b6921b01ef Closing as completed.

bnilsson11 commented 1 month ago

Where can I find the release for MacOS 10.14 with working Delete/Backspace?

dsm commented 1 month ago

You can download latest 24.3.1 macosx release in release section

bnilsson11 commented 1 month ago

Thanks, now working fine. Good work.