raa0121 / GoBCDice

GoBCDice is BCDice reimplemented by Go.
BSD 3-Clause "New" or "Revised" License
9 stars 2 forks source link

API: パスの接頭辞の表現にecho.Groupを使う #34

Closed ochaochaocha3 closed 5 years ago

ochaochaocha3 commented 5 years ago

https://echo.labstack.com/guide/routing を見ると、echo.Groupがサブルータとして使える旨が書いてあり、BaseControllerがそれと同じ役割を担っていました(作り直しに相当)。そこで、v1のコントローラにv1用のGroupを持たせ、それを用いてルーティングを定義するように変えました。

codecov[bot] commented 5 years ago

Codecov Report

Merging #34 into version-controller will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           version-controller    #34   +/-   ##
=================================================
  Coverage                  76%    76%           
=================================================
  Files                      46     46           
  Lines                    2267   2267           
=================================================
  Hits                     1723   1723           
  Misses                    422    422           
  Partials                  122    122

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b8a8bde...1782368. Read the comment docs.