raa0121 / GoBCDice

GoBCDice is BCDice reimplemented by Go.
BSD 3-Clause "New" or "Revised" License
9 stars 2 forks source link

上方無限ロールを実装する #38

Closed ochaochaocha3 closed 5 years ago

ochaochaocha3 commented 5 years ago

上方無限ロール xUn を実装しました。

GoBCDice_URoll

Ruby版との違いは以下のとおりです。

また、今回の実装中にソースコードの肥大化や多くの重複部分が見られたため、ファイルの分割や構造体の共通化といった大規模なリファクタリングを行いました。そのため、変更ファイル数がとても多くなっていますが、過去に書かれたテストはすべて通過しており、動作への影響はないと考えられます。

codecov[bot] commented 5 years ago

Codecov Report

Merging #38 into master will increase coverage by 1.02%. The diff coverage is 85.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   77.45%   78.48%   +1.02%     
==========================================
  Files          52       64      +12     
  Lines        2555     2840     +285     
==========================================
+ Hits         1979     2229     +250     
- Misses        439      456      +17     
- Partials      137      155      +18
Impacted Files Coverage Δ
pkg/core/object/object.go 75% <ø> (ø) :arrow_up:
pkg/core/object/r_roll_comp_result.go 100% <100%> (ø) :arrow_up:
pkg/core/ast/command.go 100% <100%> (ø) :arrow_up:
pkg/core/ast/basic_infix_expression.go 100% <100%> (ø)
pkg/core/ast/b_roll_list.go 100% <100%> (ø) :arrow_up:
pkg/core/evaluator/reroll_threshold.go 85.18% <100%> (+4.23%) :arrow_up:
pkg/core/evaluator/partial_eval_of_compare.go 66.66% <100%> (-4.77%) :arrow_down:
pkg/core/util/clone.go 100% <100%> (ø)
pkg/core/evaluator/determine_values.go 89.06% <100%> (-0.17%) :arrow_down:
pkg/core/ast/divide.go 96.66% <100%> (+2.91%) :arrow_up:
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ed92696...622f874. Read the comment docs.