raae / pow-app

Take charge of your menstrual cycle with POW! — the privacy-first menstrual cycle journal
https://www.usepow.app/
GNU General Public License v3.0
33 stars 2 forks source link

feat: Show error page when you onboard with no last period date, fixes #245 #268

Closed SaraVieira closed 3 years ago

SaraVieira commented 3 years ago

Closes #245

Fixes error when you create an account and do not fill your last period date by asking again

Let me know how you feel about the copy

CleanShot 2021-05-11 at 00 48 46@2x
raae commented 3 years ago

I am testing out these types of PR review messages: https://conventionalcomments.org/

raae commented 3 years ago

FYI: Something is up with deployment on Netlify, so no need to worry about failing deploys.

SaraVieira commented 3 years ago

oh, but that's sad because I it makes things so much easier :(

SaraVieira commented 3 years ago

thought (non-blocking): Should it be it's own page?

I will pick this up after lunch so we can have a base for these types of pages :)

raae commented 3 years ago

oh, but that's sad because I it makes things so much easier :(

It works if I go in and do "clear cache and deploy site" so will do that for you whenever you ask ;) Also hoping to fix soon...

SaraVieira commented 3 years ago

@raae New page at /incomplete added with the info and also added a toast component

let me know what you think

SaraVieira commented 3 years ago

All done and re-requested another review :)

raae commented 3 years ago

All done and re-requested another review :)

Did you forget to push? Last commit is "create new page && add toast"

SaraVieira commented 3 years ago

Yes i did because me idiot 😅

Done

raae commented 3 years ago

It looks good, but I will do a proper test with a clear mind tomorrow morning.

raae commented 3 years ago

I think this should be an easy merge from main.

SaraVieira commented 3 years ago

Hey!

Sorry I did not forget to push just had a super complicated week, have much more time from today on :)

raae commented 3 years ago

No problem. Just had to check you were not waiting for me 😬

SaraVieira commented 3 years ago

Should I merge now or wait for Tuesday?

raae commented 3 years ago

Feel free to merge!