Closed SaraVieira closed 3 years ago
I am testing out these types of PR review messages: https://conventionalcomments.org/
FYI: Something is up with deployment on Netlify, so no need to worry about failing deploys.
oh, but that's sad because I it makes things so much easier :(
thought (non-blocking): Should it be it's own page?
I will pick this up after lunch so we can have a base for these types of pages :)
oh, but that's sad because I it makes things so much easier :(
It works if I go in and do "clear cache and deploy site" so will do that for you whenever you ask ;) Also hoping to fix soon...
@raae New page at /incomplete added with the info and also added a toast component
let me know what you think
All done and re-requested another review :)
All done and re-requested another review :)
Did you forget to push? Last commit is "create new page && add toast"
Yes i did because me idiot 😅
Done
It looks good, but I will do a proper test with a clear mind tomorrow morning.
I think this should be an easy merge from main.
Hey!
Sorry I did not forget to push just had a super complicated week, have much more time from today on :)
No problem. Just had to check you were not waiting for me 😬
Should I merge now or wait for Tuesday?
Feel free to merge!
Closes #245
Fixes error when you create an account and do not fill your last period date by asking again
Let me know how you feel about the copy