search

raamana / hiwenet

Histogram-weighted Networks for Connectivity & Advanced Analysis in Neuroscience
http://hiwenet.readthedocs.io
MIT License
8 stars 2 forks source link

Python 3 compatibility #6

Closed raamana closed 6 years ago

raamana commented 7 years ago

Due to single a statement not compatible with Python 3+ in medpy at https://github.com/loli/medpy/blob/master/medpy/core/logger.py#L94

The current version on GitHub shows it as fixed, but not the one on PyPI (3 years old)

I'm unable to upgrade hiwenet to python 3+ easily.

Need to figure out workarounds - perhaps restricting medpy import to very specific things (not ever getting that error).

raamana commented 7 years ago

the current implementation passes successfully with 2.7 https://travis-ci.org/raamana/hiwenet/jobs/271788219

but not with 3+ due to medpy not being compatible with py3+.

oesteban commented 7 years ago

Hi, I have contacted the author of medpy (Oskar). He will try to push for Python 3 compatibility ASAP. I know Oskar and I'm pretty sure he meant it. However, I don't think the Python 3 compatibility is necessary for the JOSS submission. It may happen after acceptance.

raamana commented 7 years ago

Thanks Oscar (with a c), and you and Oskar (with k) are both amazing :)

I am going to try contribute to medpy in other areas as well as I go along.