raamana / hiwenet

Histogram-weighted Networks for Connectivity & Advanced Analysis in Neuroscience
http://hiwenet.readthedocs.io
MIT License
8 stars 2 forks source link

[JOSS Review] API is not documented #7

Closed oesteban closed 7 years ago

oesteban commented 7 years ago

Methods are documented with docstrings, but no automated method to produce the API documentation is available. Using sphinx would be really straightforward to document this project properly.

This software would really improve if documentation was built automatically and served by a third-party service like http://readthedocs.org

(ref. https://github.com/openjournals/joss-reviews/issues/380)

raamana commented 7 years ago

Hey Oscar, check the docs website now: http://hiwenet.readthedocs.io

The API page compiles properly locally, but not on RTD. It did once, it seems it is flaky when using sphinx-argparse extension. Will work with them to fix it.

raamana commented 7 years ago

Actually, it just worked again :). Open this if you have suggestions to improve.

Thanks for your comments Oscar, really improving the repo.

oesteban commented 7 years ago

Thanks a lot, this is a lot more convenient.

Some minor suggestions:

raamana commented 7 years ago

Done.

I don't think the reference to original implementation is so important.

oesteban commented 7 years ago

The fact that there is a primitive/original implementation in Matlab is irrelevant, just a circumstance. However, being transparent about the fact is very important.