Open WillForan opened 3 years ago
Thanks a lot Will for putting pyradigm to test and reporting these bugs!
Let me look into them and see why they that happened. but these bugs hopefully haven't prevented you from running comparisons? I am zoom and we can discuss this more if you want -- and to prepare for the "progress report" so to say.
I had a few bugs (using wrong variable name), and realized I never got yelled at for providing bad feature names.
A few observations:
1) feature name length doesn't have to match features.
there can be too many (x, y, z and an additional "DNE" name)
or too few (only x, but have x, y, and z)
2) specifying feature names for one samplet changes names everywhere?
this is a potentially surprising when features given to
add_samplet
in a different order -- even iffeature
andfeature_names
are paired correctly (@raamana -- a thing you warned me to check. good eye!)