search

raamana / pyradigm

Research data management in biomedical and machine learning applications
http://raamana.github.io/pyradigm/
MIT License
28 stars 13 forks source link

Python 3 ImportError #6

Closed stsievert closed 7 years ago

stsievert commented 7 years ago

I installed with pip install pyradigm. Then with Python 3.6,

In [2]: import pyradigm
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-2-1e91a6f90dae> in <module>()
----> 1 import pyradigm

/Users/scott/anaconda/lib/python3.6/site-packages/pyradigm/__init__.py in <module>()
      1
----> 2 from pyradigm import MLDataset
      3
      4 __all__ = [ 'pyradigm', 'MLDataset' ]
      5

ImportError: cannot import name 'MLDataset'

But under Python 2.7:

In [1]: from pyradigm import MLDataset

In [2]:
raamana commented 7 years ago

Thanks Scott, I will improve the compatibility with py3+ soon, but should this hold back the acceptance? I think Ariel clarified it was encouraged, but not necessary.

raamana commented 7 years ago

Python 3.5, 3.6 and 2.7 are all supported now - with 2c35f1154976af7dd40f1a4914ebc330e4f75cb2.

check https://travis-ci.org/raamana/pyradigm

Reopen if something is amiss.

stsievert commented 7 years ago

Python 3 support is not required, but if it doesn't install under Python 3 there should be a note in the readme.

In init.py I don't think you need to specify exactly 2.7.13. 2.7 is good enough.

raamana commented 7 years ago

yes, 2.7 might be enough, but I wanted to be specific as to what was being tested for support.

stsievert commented 7 years ago

Can you be specific in other places, and not enforce that the version must be 2.7.13?

the revision number is incremented when minor bugs are fixed. https://en.m.wikipedia.org/wiki/Software_versioning

So 2.7.13 should only have minor bug fixes, which is true according to the 2.7.13 changelog.