search

raamcosta / compose-destinations

Annotation processing library for type-safe Jetpack Compose navigation with no boilerplate.
https://composedestinations.rafaelcosta.xyz
Apache License 2.0
3.22k stars 133 forks source link

When to expect rc/ release version of v2 #681

Closed miduch closed 1 month ago

miduch commented 2 months ago

Hi, is it possible to get some rough idea when to expect rc/release version of v2 lib ?

thanks!

raamcosta commented 2 months ago

I’ve been hesitant only because I’m working on KMP support and it may cause some changes to the library APIs or behaviour. Given I’m on this beta state, the changes would be more expected.

That said, v2 works great with no known issues. So you don’t have to be hesitant to adopt it. Changes will be well documented on release notes and I don’t expect anything that would be hard to adapt to.

wukaicheng commented 2 months ago

Release a version using Navigation 2.8.0-release first? @raamcosta

raamcosta commented 2 months ago

Already done. Oops I may have forgotten about the GitHub release and release notes though 😅

anyway last v2 and v1 versions already using stable compose 1.7 and navigation 2.8

I’ll create the release here on GitHub 👍

miduch commented 2 months ago

I’ve been hesitant only because I’m working on KMP support and it may cause some changes to the library APIs or behaviour. Given I’m on this beta state, the changes would be more expected.

That said, v2 works great with no known issues. So you don’t have to be hesitant to adopt it. Changes will be well documented on release notes and I don’t expect anything that would be hard to adapt to.

https://github.com/raamcosta/compose-destinations/issues/661 is blocker to take v2 in use (atleast for us). Other than this, have not really find any issue and v2 seems to work great

raamcosta commented 2 months ago

Fair enough, note that it is only for start destinations with arguments and seems to be under specific situations. But it’s a strange thing for sure, I will be checking it asap 🙂

miduch commented 2 months ago

note that it is only for start destinations with arguments and seems to be under specific situations

call us unlucky but we exactly have this situation :) ending up with TitleBar showing {title} as title text for a while before it shows actual title :)

miduch commented 1 month ago

Issue seem to have disappeared in 2.1.0-beta12

https://github.com/raamcosta/compose-destinations/issues/661#issuecomment-2348725527

raamcosta commented 1 month ago

I'm closing this as I don't think it's really tracking anything useful, but thanks for opening!

UKMIITB commented 4 days ago

@raamcosta Any tentative timeline to mark v2 as stable. As long as it has beta tagged to it, we cannot use it in our production app

UKMIITB commented 4 days ago

@raamcosta Bumping this up