* Add support for organizing Redirects into categories

raamdev / wp-redirects

Redirects (a new Post Type) for WordPress®.

1 stars 2 forks source link

* Add support for organizing Redirects into categories #1

Closed raamdev closed 11 years ago

raamdev commented 11 years ago

Create custom hierarchical taxonomy 'redirect_category' to allow categorizing redirects. This is extremely helpful when sites have a large number of redirects.

jaswrks commented 11 years ago

Nice :-) I will review shortly.

jaswrks commented 11 years ago

I'm merging this in now, and I will test it myself soon before I commit to Wordpress.org. Thanks for adding translation support there too. I need to update the other parts of this plugin to add translation support in other areas also.

raamdev commented 11 years ago

I was just thinking about how I named the new taxonomy redirect_category and I was thinking that it might be possible for that to cause a conflict, as I can see someone else creating a redirect_category taxonomy for something else.

That made me think about the redirect Custom Post Type name that this plugin is using. That name seems extremely generic and could potentially cause a conflict where another plugin creates the same Custom Post Type.

In any case, doesn't it make more sense to name those ws_redirect and ws_redirect_category? Neither of those names will show up anywhere on the front-end of the plugin anyway.

jaswrks commented 11 years ago

That made me think about the redirect Custom Post Type name that this plugin is using. That name seems extremely generic and could potentially cause a conflict where another plugin creates the same Custom Post Type.

Yea, I agree it is generic. Although I think perhaps we deserve that name. This is the WP Redirect plugin after all :-) I would agree to changing it though. However, I believe changing it now would break existing installations of this plugin; because existing redirects are stored in the wp_posts table with column name post_type = redirect.

raamdev commented 11 years ago

However, I believe changing it now would break existing installations of this plugin; because existing redirects are stored in the wp_posts table with column name post_type = redirect.

Good point. I guess we should just leave things as-is then. For future reference, I think it's always good to err on the side of assuming that somebody else's plugin will cause a conflit which would make our plugin look bad, regardless of how much we deserve the name. ;)

jaswrks commented 11 years ago

Agreed :-)