search

raaz-crypto / raaz

Cryptographic library for Haskell
Apache License 2.0
68 stars 24 forks source link

Add travis build entry for liquid haskell checks #369

Closed sooryan closed 6 years ago

piyush-kurur commented 6 years ago

Since you sqashed the changes, I am not sure if you are done with the update. Also interestingly this commit is only building against Appveyor and not travis which is where our interest lies. Not sure what is happening

sooryan commented 6 years ago

This was the update just for travis. It's done. I'll check out why it isn't building against travis.

piyush-kurur commented 6 years ago

Okey I will merge your changes when you give me a go-ahead. Meanwhile I am doing some code cleanup which most likely will not things in this branch.

I would be making some more changes to travis mainly getting ghc-8.6.1 build up. If it happens before your merge be ready to do a rebase -i

sooryan commented 6 years ago

Looks like it works now. The issue was that it wasn't able to parse the .travis.yml file earlier. Missing quotes around the ppa for the apt sources.

piyush-kurur commented 6 years ago

There are couple of things.

Of course liquid haskell should be in the allowed failures section. But then the failure should give a red cross instead of the green tick. My guess is that the liquid haskell executables's exit status is not failure even when the checks fail.

sooryan commented 6 years ago

How do you propose I do the liquid failing check? I could pipe the output to a text file and grep for failure. Would that be an acceptable solution?

piyush-kurur commented 6 years ago

On Thu, Jul 05, 2018 at 07:38:16AM -0700, J.M. Soorya Narayan wrote:

How do you propose I do the liquid failing check? I could pipe the output to a text file and grep for failure. Would that be an acceptable solution?

I mean first confirm the exit status of the liquid haskell executable. If it is not then it even makes sense to raise a ticket on the liquid haskell repository.

sooryan commented 6 years ago

Hey, sorry about the delay. I was traveling.

So the exit status was always 0 because find -exec always returns that. I changed it to use xargs. It works locally but I'm not sure why it isn't reflected in the travis build.