search

rabbibotton / clog

CLOG - The Common Lisp Omnificent GUI
Other
1.51k stars 104 forks source link

Global control of client-movement #127

Closed mmontone closed 2 years ago

mmontone commented 2 years ago

Hi.

I would like to control global value of client-movement using a global variable as default that can be changed to switch between client/server movement when it has not been explicitly specified.

Do you agree?

rabbibotton commented 2 years ago

When would you be changing this value during run time? If at compile time just create a global in your code and pass that to the parameter. I have cases in code that some windows are client and some are server controlled in the same app.

On Tue, May 10, 2022, 9:10 AM Mariano Montone @.***> wrote:

Hi.

I would like to control global value of client-movement using a global variable as default that can be changed to switch between client/server movement when it has not been explicitly specified.

Do you agree?

You can view, comment on, or merge this pull request online at:

https://github.com/rabbibotton/clog/pull/127 Commit Summary

File Changes

(1 file https://github.com/rabbibotton/clog/pull/127/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/rabbibotton/clog/pull/127, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACYUEFPUTC7XWNWUIP4DB4LVJJN4XANCNFSM5VRRGLYQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

mmontone commented 2 years ago

El 10/5/22 a las 11:19, David Botton escribió:

When would you be changing this value during run time? If at compile time just create a global in your code and pass that to the parameter. Yes, but I think it could be convenient to just be able to turn on/off globally. For example, when going through the clog demos, I can turn on client-movement and see how it behaves without having to modifiy all the code and pass the parameter. I have cases in code that some windows are client and some are server controlled in the same app.

You would still have control over that passing parameter. This is just a global default.

On Tue, May 10, 2022, 9:10 AM Mariano Montone @.***> wrote:

Hi.

I would like to control global value of client-movement using a global variable as default that can be changed to switch between client/server movement when it has not been explicitly specified.

Do you agree?

You can view, comment on, or merge this pull request online at:

https://github.com/rabbibotton/clog/pull/127 Commit Summary

  • f122007

https://github.com/rabbibotton/clog/pull/127/commits/f12200724bbbf51dd9b7c01d501cb2be6d938f0e Global control of client-movement

File Changes

(1 file https://github.com/rabbibotton/clog/pull/127/files)

  • M source/clog-gui.lisp

https://github.com/rabbibotton/clog/pull/127/files#diff-580421e5bbcbbfb40934d5fd2f6c661770cf973815925de1a648628eab0d3933 (16)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/rabbibotton/clog/pull/127, or unsubscribe

https://github.com/notifications/unsubscribe-auth/ACYUEFPUTC7XWNWUIP4DB4LVJJN4XANCNFSM5VRRGLYQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/rabbibotton/clog/pull/127#issuecomment-1122461910, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADKPDV6ZZ6QTGKOY6WC2FDVJJV73ANCNFSM5VRRGLYQ. You are receiving this because you authored the thread.Message ID: @.***>

rabbibotton commented 2 years ago

Can you give me the practical case so I can think it over?

On Tue, May 10, 2022, 10:26 AM Mariano Montone @.***> wrote:

El 10/5/22 a las 11:19, David Botton escribió:

When would you be changing this value during run time? If at compile time just create a global in your code and pass that to the parameter. Yes, but I think it could be convenient to just be able to turn on/off globally. For example, when going through the clog demos, I can turn on client-movement and see how it behaves without having to modifiy all the code and pass the parameter. I have cases in code that some windows are client and some are server controlled in the same app.

You would still have control over that passing parameter. This is just a global default.

On Tue, May 10, 2022, 9:10 AM Mariano Montone @.***> wrote:

Hi.

I would like to control global value of client-movement using a global variable as default that can be changed to switch between client/server movement when it has not been explicitly specified.

Do you agree?

You can view, comment on, or merge this pull request online at:

https://github.com/rabbibotton/clog/pull/127 Commit Summary

  • f122007

< https://github.com/rabbibotton/clog/pull/127/commits/f12200724bbbf51dd9b7c01d501cb2be6d938f0e

Global control of client-movement

File Changes

(1 file https://github.com/rabbibotton/clog/pull/127/files)

  • M source/clog-gui.lisp

< https://github.com/rabbibotton/clog/pull/127/files#diff-580421e5bbcbbfb40934d5fd2f6c661770cf973815925de1a648628eab0d3933

(16)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/rabbibotton/clog/pull/127, or unsubscribe

< https://github.com/notifications/unsubscribe-auth/ACYUEFPUTC7XWNWUIP4DB4LVJJN4XANCNFSM5VRRGLYQ

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/rabbibotton/clog/pull/127#issuecomment-1122461910, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AADKPDV6ZZ6QTGKOY6WC2FDVJJV73ANCNFSM5VRRGLYQ . You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/rabbibotton/clog/pull/127#issuecomment-1122470857, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACYUEFJFBCPDPDP6OQ4JUBDVJJW27ANCNFSM5VRRGLYQ . You are receiving this because you commented.Message ID: @.***>

mmontone commented 2 years ago

El 10/5/22 a las 11:30, David Botton escribió:

Can you give me the practical case so I can think it over?

Let's say I load one of clog-gui demos, and I want to enable/disable client window movement to observe the difference between server or client.

Not very important perhaps, but I thought it could be convenient.

On Tue, May 10, 2022, 10:26 AM Mariano Montone @.***> wrote:

El 10/5/22 a las 11:19, David Botton escribió:

When would you be changing this value during run time? If at compile time just create a global in your code and pass that to the parameter. Yes, but I think it could be convenient to just be able to turn on/off globally. For example, when going through the clog demos, I can turn on client-movement and see how it behaves without having to modifiy all the code and pass the parameter. I have cases in code that some windows are client and some are server controlled in the same app.

You would still have control over that passing parameter. This is just a global default.

On Tue, May 10, 2022, 9:10 AM Mariano Montone @.***> wrote:

Hi.

I would like to control global value of client-movement using a global variable as default that can be changed to switch between client/server movement when it has not been explicitly specified.

Do you agree?

You can view, comment on, or merge this pull request online at:

https://github.com/rabbibotton/clog/pull/127 Commit Summary

  • f122007

<

https://github.com/rabbibotton/clog/pull/127/commits/f12200724bbbf51dd9b7c01d501cb2be6d938f0e

Global control of client-movement

File Changes

(1 file https://github.com/rabbibotton/clog/pull/127/files)

  • M source/clog-gui.lisp

<

https://github.com/rabbibotton/clog/pull/127/files#diff-580421e5bbcbbfb40934d5fd2f6c661770cf973815925de1a648628eab0d3933

(16)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/rabbibotton/clog/pull/127, or unsubscribe

<

https://github.com/notifications/unsubscribe-auth/ACYUEFPUTC7XWNWUIP4DB4LVJJN4XANCNFSM5VRRGLYQ

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub

https://github.com/rabbibotton/clog/pull/127#issuecomment-1122461910, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AADKPDV6ZZ6QTGKOY6WC2FDVJJV73ANCNFSM5VRRGLYQ

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/rabbibotton/clog/pull/127#issuecomment-1122470857, or unsubscribe

https://github.com/notifications/unsubscribe-auth/ACYUEFJFBCPDPDP6OQ4JUBDVJJW27ANCNFSM5VRRGLYQ . You are receiving this because you commented.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/rabbibotton/clog/pull/127#issuecomment-1122475368, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADKPDSZGRDJBG4DO4L5PH3VJJXINANCNFSM5VRRGLYQ. You are receiving this because you authored the thread.Message ID: @.***>

rabbibotton commented 2 years ago

A may consider adding a global to one of the tutorials, but I don't think it makes sense to change the framework. The only reason for changing to start with is to moderate network traffic or add responsiveness on slow networks and I think those type of changes should be thought out on a window by window basis.