rabbibotton / clog

CLOG - The Common Lisp Omnificent GUI
Other
1.48k stars 101 forks source link

Introduce a new low level creation for clog element: 'create-element' #286

Closed jingtaozf closed 5 months ago

jingtaozf commented 1 year ago

It is useful to integrate with bootstrap, for example:

(create-element toolbar-row :div :class "btn-toolbar" :role "toolbar" :aria-label "Toolbar")

Or:

(create-element toolbar-group-1 :button :content "F" :class "btn btn-primary" :title "a tooltip for a button")
rabbibotton commented 6 months ago

I plan on merging this at some point, but since you included https://github.com/rabbibotton/clog/pull/290 I first need to work out the potential issues first. I am now coding again after long break so hopefully won't be too long.

rabbibotton commented 5 months ago

I need to see how to prevent the portion that was #290 and then merge this.

jingtaozf commented 5 months ago

@rabbibotton Is it possible for me to initiate a new pull request that solely includes create-element? I can likewise incorporate other modifications in subsequent pull requests as well.

rabbibotton commented 5 months ago

perfect

On Mon, Jan 15, 2024 at 8:35 PM Jingtao Xu @.***> wrote:

@rabbibotton https://github.com/rabbibotton Is it possible for me to initiate a new pull request that solely includes create-element? I can likewise incorporate other modifications in subsequent pull requests as well.

— Reply to this email directly, view it on GitHub https://github.com/rabbibotton/clog/pull/286#issuecomment-1892945142, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACYUEFJR4LD3T4A7RY3COL3YOXKNDAVCNFSM6AAAAAAZT3M7KKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJSHE2DKMJUGI . You are receiving this because you were mentioned.Message ID: @.***>

jingtaozf commented 5 months ago

I created a new pull request for create-element: https://github.com/rabbibotton/clog/pull/320