rabbibotton / clog

CLOG - The Common Lisp Omnificent GUI
Other
1.48k stars 101 forks source link

clog-db-table doesn't place td elements inside rows #314

Closed raineszm closed 5 months ago

raineszm commented 8 months ago

The next-row method on clog-db-table generates html like

<tr></tr>
<td>col1</td><td>col2</td>

Probably this should be

<tr><td>col1</td><td>col2</td></tr>

This can be fixed with the change

diff --git a/source/clog-dbi.lisp b/source/clog-dbi.lisp
index d18557f..6e2c5ed 100644
--- a/source/clog-dbi.lisp
+++ b/source/clog-dbi.lisp
@@ -427,7 +427,7 @@ the displayed option."
           (funcall (on-row obj) obj tr))
         (loop for (key value) on row by #'cddr while value
               do
-                 (let ((td (create-table-column obj :content value)))
+                 (let ((td (create-table-column tr :content value)))
                    (when (on-column obj)
                      (funcall (on-column obj) obj key td)))))))
   (when (on-footer obj)

Happy to submit a PR if that's easier, and thanks for the wonderful tool.

rabbibotton commented 5 months ago

done, sorry for delay