rabbit-shocker / rabbit

A programmable presentation tool by Ruby.
http://rabbit-shocker.org/
Other
255 stars 42 forks source link

test/test-applier.rb#normalize_source requires keep option supported test/unit/data. #126

Closed dai-vdr closed 5 years ago

dai-vdr commented 5 years ago

Debian has only test-unit 3.2.8 currently and rabbit 3.0.0 has failed to test with test-unit 3.2.8:

/usr/lib/ruby/vendor_ruby/test/unit/data.rb:67:in `data': wrong number arguments(3 for 1..2) (ArgumentError)
    from /tmp/autopkgtest-lxc.rnohdrmy/downtmp/build.5Ts/real-tree/test/test-applier.rb:33:in `block in <class:RabbitApplierTest>'
    from /usr/lib/ruby/vendor_ruby/test/unit/testcase.rb:379:in `class_eval'
    from /usr/lib/ruby/vendor_ruby/test/unit/testcase.rb:379:in `sub_test_case'
    from /tmp/autopkgtest-lxc.rnohdrmy/downtmp/build.5Ts/real-tree/test/test-applier.rb:28:in `<class:RabbitApplierTest>'
    from /tmp/autopkgtest-lxc.rnohdrmy/downtmp/build.5Ts/real-tree/test/test-applier.rb:19:in `<top (required)>'

Rabbit 3.0.0's test/test-applier.rb#normalize_source requires keep option supported test/unit/data with test-unit >= 3.2.9.

kou commented 5 years ago

Is it OK that you can't run Rabbit's test on Debian?

dai-vdr commented 5 years ago

All autopkgtest failures considered RC for bullseye. But I will ask debian-ruby ML to update test-unit. If Debian's test-unit is updated to > 3.2.8, this pull-req is not required.

kou commented 5 years ago

Thanks. We can omit tests that need test-unit 3.2.9 until Debian ships test-unit 3.2.9 or later.

dai-vdr commented 5 years ago

I uploaded test-unit 3.2.9 to Debian: https://alioth-lists.debian.net/pipermail/pkg-ruby-extras-maintainers/2019-September/048777.html

kou commented 5 years ago

Thanks. Then can we close this pull request?

dai-vdr commented 5 years ago

Thank you for your support. I closed it.