search

rabbitholegg / quest-protocol

Quests Protocol is a protocol to distribute token rewards for completing on-chain tasks.
GNU General Public License v3.0
89 stars 23 forks source link

Confirm branches pass linting before merge #165

Closed Quazia closed 1 year ago

Quazia commented 1 year ago

Right now it's up to the developer to enforce linting on the code they submit. For this issue we want to ensure that linting is checked on each PR using solhint before it can be merged into main using GitHub actions.

waynehoover commented 1 year ago

Can you also add solidity to .vscode/extensions.json and a .solhint file to the repo and "solidity.linter": "solhint", to .vscode/settings.json for us vscode users.

waynehoover commented 1 year ago

Also, while we are at let's move over to forge for formatting and set up the vscode workspace for it too: https://book.getfoundry.sh/config/vscode#3-formatter

Quazia commented 1 year ago

Definitely on both counts

Quazia commented 1 year ago

Closed by #173