rabbitmq / chef-cookbook

Development repository for Chef cookbook RabbitMQ
https://supermarket.chef.io/cookbooks/rabbitmq
Apache License 2.0
214 stars 423 forks source link

Incorrect config file path when deploying Rabbit 3.6.x #564

Closed aprice closed 4 years ago

aprice commented 4 years ago

Due to the default config file path and the config file path helper, the cookbook saves the config file as /etc/rabbitmq/rabbitmq by default rather than /etc/rabbitmq/rabbitmq.conf for deployments of RabbitMQ v3.6.x.

michaelklishin commented 4 years ago

Which is actually the correct thing to do: RabbitMQ 3.6 does not support the new style config format and IIRC does not support config file paths with the .config extension.

Note that 3.6 has been out of support for over two years.

aprice commented 4 years ago

"In other news" the cookbook starts off with:

This is a cookbook for managing RabbitMQ with Chef. It is intended for RabbitMQ 2.6.1 or later releases.

Nice attitude toward your own community though.

michaelklishin commented 4 years ago

@aprice I'm sorry that my response offended you.

I don't see any mentions the quoted line in this repository or on the Chef Supermarket page. There should be no references to 3.6 in any of the examples or even tests.

Please clarify where you are getting this from?

michaelklishin commented 4 years ago

Here is what the README says at the moment. The section on supported RabbitMQ series was a little further down before (this can be seen on the Supermarket page) but nonetheless, no mentions of 2.6.1 or even 3.6.x:

Chef RabbitMQ cookbook README supported versions

Let me know what can be clarified further, or where.

RabbitMQ 3.6 releases can still be provisioned but all documentation targets 3.8 (and except for features such as quorum queues or feature flags, this generally applies to 3.7.27), both for RabbitMQ itself or this cookbook.