Fix backlash handling on permissions

[dud225]

What types of changes does your code introduce to this project? Put an x in the boxes that apply

• [X] Bug fix (non-breaking change which fixes issue #565)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] Documentation (correction or otherwise)
• [ ] Cosmetics (whitespace, appearance)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask on the mailing list. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• [X] I have read the CONTRIBUTING.md document
• [X] I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
• [ ] All tests pass locally with my changes
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] I have added necessary documentation (if appropriate)
• [ ] Any dependent changes have been merged and published in related repositories

[michaelklishin]

Thank you. I would like to see a test case (Test Kitchen or a bunch of unit tests for a function that would do this) to go with this change.

[dud225]

Hello. It is actually difficult to test. The function where the condition that is being fixed lies serves as a guard to prevent the permissions from being set again. So to test it we would need to run Chef twice and check that the permissions are not set again on the second run.

[michaelklishin]

Surely the encoding part can be extracted into a library function that should be trivial to test. But we don't really have any tests for library functions and it's not 100% clear to me how these are commonly tested in the case of Chef. Perhaps as any other library functions :/