search

rabbitmq / chef-cookbook

Development repository for Chef cookbook RabbitMQ
https://supermarket.chef.io/cookbooks/rabbitmq
Apache License 2.0
214 stars 423 forks source link

Invalid configuration produced for Ubuntu 22.04 / 3.9.13 #608

Open doconnor-clintel opened 1 year ago

doconnor-clintel commented 1 year ago

Describe the bug

On start:

2023-04-26 05:17:33.409279+00:00 [warning] <0.469.0> Transport option binary unknown or invalid.
2023-04-26 05:17:33.409279+00:00 [warning] <0.469.0> 
2023-04-26 05:17:33.409395+00:00 [warning] <0.469.0> Transport option {packet,raw} unknown or invalid.
2023-04-26 05:17:33.409395+00:00 [warning] <0.469.0> 
2023-04-26 05:17:33.409459+00:00 [warning] <0.469.0> Transport option {reuseaddr,true} unknown or invalid.
2023-04-26 05:17:33.409459+00:00 [warning] <0.469.0>

These are configured via: https://github.com/rabbitmq/chef-cookbook/blob/v5.x/templates/default/rabbitmq.config.erb#L77

This seems to have been removed in ~2016: https://bugs.launchpad.net/fuel/+bug/1570323/comments/5

Reproduction steps

  1. Cook an Ubuntu 22.04 machine, using system packages
  2. Have it install 3.9.13 3.tail -n 100 /var/log/rabbitmq/rabbit@localhost.log

Expected behavior

No deprecated config options for more modern versions

Additional context

No response

doconnor-clintel commented 1 year ago

https://github.com/voxpupuli/puppet-rabbitmq/pull/464 is basically this but for puppet.

michaelklishin commented 1 year ago

3.9 is not a modern version, in fact, it is has been out of support for a few months now. 3.12 is expected to ship next month.

Feel free to submit a PR that removes that option. It's an Erlang setting and RabbitMQ requires very recent Erlang releases so it should be fine to remove the option for all distributions.