search

rabbitmq / chocolatey-package

RabbitMQ chocolatey package
20 stars 26 forks source link

Allow option for *not* installing Windows Service via the Windows Installer #133

Open Vacant0mens opened 2 months ago

Vacant0mens commented 2 months ago

Is your feature request related to a problem? Please describe.

When running the chocolatey installer, if the rabbitmq-service.bat install script fails, the entire install will fail, and if run via remote access (e.g. Remote PowerShell), the install process hangs because of a pop-up error message box.

Installing RabbitMQ with the regular GUI installer allows you to un-check the "RabbitMQ Service" option, which will help the initial install succeed, and then installing the Service can be troubleshot after.

Without the option in the chocolatey package, it is very difficult to troubleshoot why the service doesn't install.

Describe the solution you'd like

an option added to the chocolatey install command to allow one to skip the service install, if desired.

Describe alternatives you've considered

manually downloading the .exe installer and running it by hand. ... which defeats the purpose of the chocolatey package.

Additional context

In my case, the error I saw from rabbitmq-service.bat install (while installing v3.12.6) was this: C:\Program Files\Erlang OTP\erts-14.0.2\bin\erlsrv: Unrecognized option {child_type,worker}].

But the service was still installed and ran successfully. This error shows after the Service RabbitMQ added to System message.

michaelklishin commented 2 months ago

@Vacant0mens since no one else in close to a decade has requested this option, you are welcome to scratch your own itch and contribute it.

Vacant0mens commented 2 months ago

I don't know anything about windows installers. Otherwise I would.

michaelklishin commented 2 months ago

@Vacant0mens I'm afraid open source software does not mean "free labor on the Internet", so you will have to learn a thing or two. You get the software for free under a true open source license after all.

This is a (literally) fifty lines of code long installer. The Windows installer it wraps is about 500 lines long and the most relevant part where you can inject a new condition is three lines long.

Vacant0mens commented 2 months ago

@michaelklishin I don't want to sound like a jerk, but please don't assume I'm out here begging for "free labor". I know plenty about scripting and software development, and I've contributed a fair amount to the open source community, and I've even spent weeks of my time automating the automation for the RabbitMQ install and setup process. The fact that I've never had to dig into what it takes to make a Windows Installer doesn't make me incompetent. I was being honest and literal about not knowing anything about it. Thank you for pointing out that it's short, but until I have time to look into it, I already have a workaround. I was just hoping someone who knows more about it than me would have a few minutes to look at it, rather than me spending hours stumbling around trying to learn a new utility and how it's being used.

I also don't appreciate the comment on the other discussion that you assumed was another whine for free labor, instead of looking at it objectively and politely like lukebakken did. Please be more professional next time.