search

rabbitmq / cluster-operator

RabbitMQ Cluster Kubernetes Operator
https://www.rabbitmq.com/kubernetes/operator/operator-overview.html
Mozilla Public License 2.0
884 stars 273 forks source link

force string for resource attributes in examples #1647

Closed nicoangelo closed 5 months ago

nicoangelo commented 5 months ago

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

This fixes the datatype of the resource attributes in the production ready example. Otherwise this example will cause CD tools like Flux, to constantly update the resource and change it back to a numeric value. Since the production-ready example is rather prominently mentioned in the docs, I think it might make sense to provide an example that doesn't trigger changes by CD tools (even though using a numeric is allowed).

mkuratczyk commented 5 months ago

Thanks. This sounds like a bug in Flux to be honest, but 🤷