search

rabbitmq / cluster-operator

RabbitMQ Cluster Kubernetes Operator
https://www.rabbitmq.com/kubernetes/operator/operator-overview.html
Mozilla Public License 2.0
881 stars 272 forks source link

Add connection_string secret to default_user secret #1721

Closed hxyannay closed 2 months ago

hxyannay commented 2 months ago

This closes #1722

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

Added a new key connection_string to the default_user secret with a formatted connection_string.

hxyannay commented 2 months ago

Committed your changes :) Also it would be great if you could release a new version of the operator once you merge this pull request, so I could use those changes right away.

hxyannay commented 2 months ago

Hey @Zerpet Can you take another look? Thanks!

Zerpet commented 2 months ago

I approved the PR ✅ I'll merge after CI passes. We released 2.10.0 last week, and it is a bit soon to release another version. We tend to wait for 1 month between minor releases. Plus we have some dependabot PRs that need manual intervention.

If you want to use these changes right away, I'd recommend that you build own "snapshot" version from main after merging. There's a Make target to build, and it only requires 2 inputs, see:

https://github.com/rabbitmq/cluster-operator/blob/86e948edcaf430f78ff44de8860d0ab47a548247/Makefile#L207-L210

You can build the operator locally, for example, with: 

make docker-build DOCKER_REGISTRY_SERVER=docker.io OPERATOR_IMAGE=hxyannay/rabbitmq-cluster-operator

You will have to push the image then with docker push and update the latest release manifests to use this image.

hxyannay commented 2 months ago

Great, I will build an image myself for the time being. Thank you.