rabbitmq / credentials-obfuscation

Tiny library/OTP app for credential obfuscation
Other
14 stars 8 forks source link

Include rebar3_hex in project_plugins, not plugins #23

Closed newmanjeff closed 1 year ago

newmanjeff commented 1 year ago

Proposed Changes

Moves the rebar3_hex plugin from "plugins" to "project_plugins." Including the plugin within the "plugin" section means all projects the include credentials-obfuscation as a dependency must also include the rebar3_hex plugin. Note the documentation:

NOTE : Be sure not to add rebar3_hex to the plugins section within a projects rebar3 config as this will become a dependency for others downloading your package from hex.pm

Types of Changes

What types of changes does your code introduce to this project? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask on the mailing list. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

michaelklishin commented 1 year ago

Thank you. I'll cut a new release some time tomorrow.

isaacsanders commented 1 year ago

@michaelklishin A new release was never made

lukebakken commented 1 year ago

@isaacsanders I'm getting the release now.

lukebakken commented 1 year ago

@isaacsanders @newmanjeff - https://github.com/rabbitmq/credentials-obfuscation/releases/tag/v3.3.0

isaacsanders commented 1 year ago

@isaacsanders I'm getting the release now.

Thank you!