Assorted Dockerfile improvements

[ncaio]

Dockerfile.template (_dockerfiletemp) - Corrections and handling Dockefile destination ($_docker_file)- Corrections and handling Shell script standard naming convention

• _docker_file=Dockerfile
• _docker_temp=Dockerfile.template
• _parameter1=7
• _parameter2=--no-cache
• _docker_dir=docker-centos-7
• '[' -z 7 ']'
• '[' -e Dockerfile ']'
• '[' -e docker-centos-7 ']'
• rm -rf docker-centos-7
• mkdir docker-centos-7
• '[' -e Dockerfile.template ']'
• cp Dockerfile.template docker-centos-7/Dockerfile
• sed -i 's/{centosfrom}/7/g' docker-centos-7/Dockerfile
• '[' -z --no-cache ']'
• sudo docker build --no-cache -t=erlang-rpm-build-7 docker-centos-7

[Gsantomaggio]

Hi @ncaio ! Thank you for your PR.

I left a couple of comments in the script.

There is another little improvement that you could do inside the last if You can directly pass the second parameter to docker build, docker just ignore it if does not exist . Something like:

docker_params=$2 #here you don't need "" for --no-cache parameter 
......

if [ -e "$docker_template" ]
then
        cp "$docker_template" "$docker_dir"/"$docker_file"
        sed -i 's/{centosfrom}/'$1'/g' "$docker_dir"/"$docker_file"
        sudo docker build $docker_params -t="erlang-rpm-build-""$centos_version" "$docker_dir"
fi

But it is not strictly necessary :)

[Gsantomaggio]

@ncaio Thank you

[ncaio]

you're welcome =]