search

rabbitmq / erlang-rpm

Latest Erlang/OTP releases packaged as a zero dependency RPM, just enough for running RabbitMQ
https://rabbitmq.com/install-rpm.html
Other
553 stars 118 forks source link

that JIT has not been enabled for 'erlang-24.0.3-1.el8.x86_64.rpm' #97

Closed tomyouyou closed 3 years ago

tomyouyou commented 3 years ago

I downloaded and installed the 'erlang-24.0.3-1.el8.x86_64.rpm' and found that JIT was disabled. [root@ctrl1]# erl Erlang/OTP 24 [erts-12.0.3] [source] [64-bit] [smp:2:2] [ds:2:2:10] [async-threads:1]

Eshell V12.0.3 (abort with ^G) 1>

michaelklishin commented 3 years ago

You haven't provided any evidence of that.

erlang:system_info(emu_flavor).

can be used as evidence.

The JIT is quietly excluded if the build environment is missing a C++17 compiler, so, g++ must be added to the build image.

michaelklishin commented 3 years ago

I have added BuildDepends: clang to erlang.spec. This will make sure that gcc and gcc-c++ (the missing part) are also available.

Finally, the build env images were updated to install Clang/GCC with C++.

michaelklishin commented 3 years ago

For our Concourse env to be updated, we have to update another image. I'm on it.

michaelklishin commented 3 years ago

Done. From the most recent build:

checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking for C++17 support... yes
michaelklishin commented 3 years ago

I rebuilt the 24.0.3 release and republished it, including to GitHub. There is no easy way to automatically bump the revision for this package and we don't know when a new patch release is going to come out, so I figured re-tagging and re-publishing would be the most pragmatic thing to do.