Closed mikymigs closed 6 days ago
@mikymigs you are welcome to contribute it. It should be a matter of a Jackson mapping change.
Adding a test should be reasonably straightforward, too, but if it's a matter of adding one field to an existing domain class, I'd personally accept a PR without any tests.
Thank you for your reply @michaelklishin Would be happy to contribute. I will try to propose a PR when I find the time :)
Hello @michaelklishin, Tried to push a branch it seems I don't have access rights. Can you authorize me to push branches and create PRs ?
Thanks
@mikymigs of course I won't, that's way unreasonable of an ask from a first time contributor.
You need to fork this repo, push a branch to your own fork and then submit a pull request.
Sorry, new to the github practices. Will go through a fork.
Fixed in #471.
Is your feature request related to a problem? Please describe.
ConsumerDetails
class does not map the activity_status attribute of the/api/consumers
response.Describe the solution you'd like
The
/api/consumers
call provides a list of consumers. Each consumer object in the response has anactivity_status
attribute that can have values such aswaiting
orsingle_active
. I would like it if you could add this field to theConsumerDetails
class.Other fields are missing such as
ack_required
orconsumer_timeout
. I don't necessarily need those but I don't see any reason why the lib should limit the information available via the management API (might as well build our own lib in this case...)Thanks a lot,
Describe alternatives you've considered
Using the
active
flag but it doesn't provide enough details.Additional context
No response