rabbitmq / hop

RabbitMQ HTTP API client for Java, Groovy, and other JVM languages
142 stars 57 forks source link

Add activity_status attribute to ConsumerDetails #470

Closed mikymigs closed 6 days ago

mikymigs commented 1 week ago

Is your feature request related to a problem? Please describe.

ConsumerDetails class does not map the activity_status attribute of the /api/consumers response.

Describe the solution you'd like

The /api/consumers call provides a list of consumers. Each consumer object in the response has an activity_status attribute that can have values such as waiting or single_active. I would like it if you could add this field to the ConsumerDetails class.

Other fields are missing such as ack_required or consumer_timeout. I don't necessarily need those but I don't see any reason why the lib should limit the information available via the management API (might as well build our own lib in this case...)

Thanks a lot,

Describe alternatives you've considered

Using the active flag but it doesn't provide enough details.

Additional context

No response

michaelklishin commented 1 week ago

@mikymigs you are welcome to contribute it. It should be a matter of a Jackson mapping change.

Adding a test should be reasonably straightforward, too, but if it's a matter of adding one field to an existing domain class, I'd personally accept a PR without any tests.

mikymigs commented 1 week ago

Thank you for your reply @michaelklishin Would be happy to contribute. I will try to propose a PR when I find the time :)

mikymigs commented 1 week ago

Hello @michaelklishin, Tried to push a branch it seems I don't have access rights. Can you authorize me to push branches and create PRs ?

Thanks

michaelklishin commented 1 week ago

@mikymigs of course I won't, that's way unreasonable of an ask from a first time contributor.

You need to fork this repo, push a branch to your own fork and then submit a pull request.

mikymigs commented 1 week ago

Sorry, new to the github practices. Will go through a fork.

acogoluegnes commented 6 days ago

Fixed in #471.