search

rabbitmq / lz4-erlang

LZ4 compression library for Erlang.
Other
19 stars 8 forks source link

Upgraded erlang.mk for otp 23 #9

Closed tsenturk closed 4 years ago

tsenturk commented 4 years ago

2020/03/25: The -lerl_interface argument has been removed from the default LDLIBS. This is an old library that is getting removed in OTP-23 and should no longer be used. Note that the default still includes -lei which is part of the Erlang/OTP Erl_Interface application but is built as a separate C library. The removal only applies to -lerl_interface itself.

michaelklishin commented 4 years ago

@essen @dumbbell is our our fork needed for this library or can we go with this PR?

essen commented 4 years ago

I think the fork has nothing RabbitMQ-specific it's just a slightly older version. I think the Erlang.mk file being replaced was from mainline anyway. Assuming the project still compiles and works, the PR is fine.

michaelklishin commented 4 years ago

That it does.

tsenturk commented 4 years ago

thank you @michaelklishin and @essen