search

rabbitmq / messaging-topology-operator

RabbitMQ messaging topology operator
Mozilla Public License 2.0
125 stars 66 forks source link

Better topology examples #846

Closed EnessenE closed 1 month ago

EnessenE commented 2 months ago

This closes nothing.

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed Note to contributors: remember to re-generate client set if there are any API changes

Summary Of Changes

Simply add some additional comments and examples to the topology examples made available.

Additional Context

vmwclabot commented 2 months ago

@EnessenE, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

vmwclabot commented 2 months ago

@EnessenE, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

Zerpet commented 2 months ago

We will have to wait for the CLA approval before merging. Thank you for this contribution!

EnessenE commented 2 months ago

Thanks for the quick review!

vmwclabot commented 1 month ago

@EnessenE, VMware has approved your signed contributor license agreement.