search

rabbitmq / ra

A Raft implementation for Erlang and Elixir that strives to be efficient and make it easier to use multiple Raft clusters in a single system.
Other
813 stars 96 forks source link

Handle `nosuspend` when sending applied notifications. #248

Closed kjnilsson closed 2 years ago

kjnilsson commented 2 years ago

https://github.com/rabbitmq/ra/blob/main/src/ra_server_proc.erl#L1150

pjk25 commented 2 years ago

Can we not just ignore the result as I presume notifications are do not have a requirement of delivery?

pjk25 commented 2 years ago

Do I understand it correctly that notify is a built-in effect, though not documented in https://github.com/rabbitmq/ra/blob/main/docs/internals/INTERNALS.md ?

kjnilsson commented 2 years ago

Done in #260