fix ra:overview/1 to get wal status from the configured name in the
system config, instead of using ra_log_wal, which is only valid for the
default system
Proposed Changes
Currently ra:overview/1 gets wal status by calling sys:get_status(ra_log_wal), which is only valid for the default system, and it fails with noproc if the default system is not started.
The proposed fix uses the names section from the system info to get the right name, exactly as it is already done for the segment writer, etc.
Types of Changes
What types of changes does your code introduce to this project?
Put an x in the boxes that apply
[x] Bug fix (non-breaking change which fixes issue #NNNN)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (correction or otherwise)
[ ] Cosmetics (whitespace, appearance)
Checklist
Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in related repositories
Further Comments
If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.
michaelklishin
commented
2 years ago
fix ra:overview/1 to get wal status from the configured name in the system config, instead of using ra_log_wal, which is only valid for the default system
Proposed Changes
Currently
ra:overview/1gets wal status by callingsys:get_status(ra_log_wal), which is only valid for the default system, and it fails with noproc if the default system is not started. The proposed fix uses thenamessection from the system info to get the right name, exactly as it is already done for the segment writer, etc.Types of Changes
What types of changes does your code introduce to this project? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask on the mailing list. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CONTRIBUTING.mddocumentFurther Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.