search

rabbitmq / rabbitmq-amqp1.0-client

Erlang AMQP 1.0 client
Other
20 stars 29 forks source link

Amqp Filters #17

Closed patrickdet closed 6 years ago

patrickdet commented 6 years ago

This PR adds the Amqp Filter functionality #3 to the client. Upon attaching a receiver link one can pass a map of filters.

So far I have only written a test for Azure but all the other tests are green so no existing functionality is negatively affected.

Let me know what you think. I need this functionality for an upcoming project which connects to Azure Eventhubs and since people have asked for the ability to set filters I thought it would be a good time to implement them.

pivotal-issuemaster commented 6 years ago

@patrickdet Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented 6 years ago

@patrickdet Thank you for signing the Contributor License Agreement!

michaelklishin commented 6 years ago

@patrickdet thank you. The lead maintainer of this client will be away for over a week but we have made a note.

patrickdet commented 6 years ago

Thank you @kjnilsson for the pointers. It's been a while since I have gotten to write some Erlang. I have addressed them now. Let me know what you think.

Btw would it be possible to release the client to hex.pm when/if this feature gets merged?

PS (unrelated): Big fan of Fez 👍

michaelklishin commented 6 years ago

@patrickdet a new release can take a couple of days after merging but shouldn't take long. Thank you!