search

rabbitmq / rabbitmq-amqp1.0-client

Erlang AMQP 1.0 client
Other
20 stars 29 forks source link

(Mostly) lacking URI parser tests #37

Closed michaelklishin closed 5 years ago

michaelklishin commented 5 years ago

URI parser in this client largely lacks tests. Discovered while QA'ing https://github.com/rabbitmq/rabbitmq-shovel/pull/57.

kjnilsson commented 5 years ago

Any particular cases that you found? We can add them to the tests here: https://github.com/rabbitmq/rabbitmq-amqp1.0-client/blob/master/src/amqp10_client.erl#L466

michaelklishin commented 5 years ago

I indeed tried to use a path segment.

michaelklishin commented 5 years ago

We'll consider this addressed in https://github.com/rabbitmq/rabbitmq-amqp1.0-client/commit/8ef26ead733f5366f8127518a81911c9e64589d1 for now.