search

rabbitmq / rabbitmq-amqp1.0

AMQP 1.0 support for RabbitMQ
https://www.rabbitmq.com/
Other
93 stars 20 forks source link

Fix typo in x-credit arguments. #48

Closed kjnilsson closed 7 years ago

kjnilsson commented 7 years ago

This caused the credit mechanism not to to initialise correctly with the channel limiter which had the effect that the amqp1.0 plugin would start delivering messages before credit had been granted.

[#144860529]

Fixes #43

kjnilsson commented 7 years ago

I attempted to write a test for this but the AmqpLite .NET client automatically sends a flow credit frame and this only occurs if no credit frame is sent at all.

This is, however, indirectly tested in the amqp10 client test suite.

michaelklishin commented 7 years ago

@kjnilsson @dcorbacho was this intentionally submitted against master or can it be backported?

kjnilsson commented 7 years ago

It can be back ported but we should add the amqp10 client as a test dep and write a test for this case as there is no indirect coverage for stable. On Mon, 15 May 2017 at 16:11, Michael Klishin notifications@github.com wrote:

@kjnilsson https://github.com/kjnilsson @dcorbacho https://github.com/dcorbacho was this intentionally submitted against master or can it be backported?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/rabbitmq/rabbitmq-amqp1.0/pull/48#issuecomment-301505648, or mute the thread https://github.com/notifications/unsubscribe-auth/ABIDlNJ7oGHLAmIsjQTiHQ63Wf3tWUeeks5r6Gs4gaJpZM4NQ2NZ .