rabbitmq / rabbitmq-amqp1.0

AMQP 1.0 support for RabbitMQ
https://www.rabbitmq.com/
Other
93 stars 20 forks source link

Compile on Erlang/OTP 21 #64

Closed michaelklishin closed 6 years ago

michaelklishin commented 6 years ago

Proposed Changes

This is one of the PRs that makes RabbitMQ build successfully on Erlang/OTP 21.

OTP 21 deprecated erlang:get_stacktrace/0 in favor of a new try/catch syntax. Unfortunately that's not realistic for projects that support multiple Erlang versions (like us) until OTP 21 can be the minimum version requirement. In order to compile we have to ignore the warning. The broad compiler option seems to be the most common way to support compilation on multiple OTP versions with warnings_as_errors: if we use a function-specific option it will fail on the releases where the function is not deprecated.

Types of Changes

Checklist

Further Comments

[#157964874]