Consider dropping supervisor2

rabbitmq / rabbitmq-amqp1.0

AMQP 1.0 support for RabbitMQ

https://www.rabbitmq.com/

Other

93 stars 20 forks source link

Consider dropping supervisor2 #96

Closed michaelklishin closed 3 years ago

michaelklishin commented 4 years ago

supervisor2 hasn't been updated to support map flags and child specs. While this can be corrected, we should reconsider its use. It seems to be used only in a few places and replacing it with the standard supervisor might be quite straightforward.

kjnilsson commented 4 years ago

As the supervisor2s use the intrinsic restart type I'm not sure there is an equivalent using a vanilla supervisor

https://github.com/rabbitmq/rabbitmq-amqp1.0/blob/164e5dfab8e5a767542a63a80664dccdeb13388a/src/rabbit_amqp1_0_session_sup.erl#L39

michaelklishin commented 4 years ago

The question is, do we need this restart type in most places. I bet we don't.

lukebakken commented 3 years ago

We still :heart: supervisor2 https://github.com/rabbitmq/rabbitmq-common/pull/411