Pass consul token as a header - Githubissues

rabbitmq / rabbitmq-autocluster

RabbitMQ peer discovery and cluster formation plugin, supports RabbitMQ 3.6.x

BSD 3-Clause "New" or "Revised" License

241 stars 54 forks source link

Pass consul token as a header #53

Closed akissa closed 7 years ago

akissa commented 7 years ago

Pass consul token as a header

The recommended way to pass consul tokens is now using headers, header support was introduced in consul version 0.6.0.

https://www.consul.io/api/index.html#authentication

This change is not compatible with consul versions < 0.6.0

Types of Changes

[ ] Bugfix (non-breaking change which fixes issue #NNNN)
[X] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (correction or otherwise)
[X] Cosmetics (whitespace, appearance)

Checklist

[X] I have read the CONTRIBUTING.md document
[ ] I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
[X] All tests pass locally with my changes
[X] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in related repositories

Further Comments

This change is not compatible with consul versions < 0.6.0