search

rabbitmq / rabbitmq-autocluster

RabbitMQ peer discovery and cluster formation plugin, supports RabbitMQ 3.6.x
BSD 3-Clause "New" or "Revised" License
241 stars 54 forks source link

Plugin not compatible to consul 1.0.0 #55

Closed thalesac closed 7 years ago

thalesac commented 7 years ago

Hi, I've updated consul and noticed that consul was rejecting the service registrarion with this message:

[ERR] http: Request POST /v1/agent/service/register, error: method POST not allowed from=127.0.0.1:34213

I've checked the consul changelog (https://github.com/hashicorp/consul/blob/master/CHANGELOG.md) and they now are accepting only PUT (not POST) for this endpoint.

As per https://github.com/aweber/rabbitmq-autocluster/blob/a8271e8d71b38dd917957aee0f4bd35d055f43f6/src/autocluster_consul.erl#L88 - rabbitmq-autocluster is sending a POST.

Can we change this for PUT to make it compatible?

michaelklishin commented 7 years ago

Yes it is, see 0.10.0 release notes.

thalesac commented 7 years ago

I realized that quiclkly and closed the ticket. Sorry @michaelklishin
Thanks for this plugin.

michaelklishin commented 7 years ago

@thalesac no worries, I will leave a note in the README. I mostly commented for others landing here from search results.