search

rabbitmq / rabbitmq-autocluster

RabbitMQ peer discovery and cluster formation plugin, supports RabbitMQ 3.6.x
BSD 3-Clause "New" or "Revised" License
241 stars 54 forks source link

Add startup lock support (general framework + tested etcd implementation) #6

Closed Gsantomaggio closed 7 years ago

Gsantomaggio commented 7 years ago

Moved the PR https://github.com/aweber/rabbitmq-autocluster/pull/98

michaelklishin commented 7 years ago

We will take a look after 0.7.0 GA is released.

michaelklishin commented 7 years ago

@binarin @Gsantomaggio I don't see where in the code is augment_nodelist actually used beyond the test suite. Am I missing something or can be it removed? Alternative node representation records a pretty controversial thing for us to adopt into RabbitMQ master.

michaelklishin commented 7 years ago

OK, so GitHub does not display the entire diff again. The "find best node to join" part can be a bit too opinionated for inclusion into RabbitMQ core.

michaelklishin commented 7 years ago

Available as of 0.8.0.M1.

binarin commented 7 years ago

Sadly This plugin will now pick a running reachable node that has the best uptime record from release notes is not true. While initially I though that this is a good idea, I wasn't able to come up with a solid (distributed) algorithm for this. So IIRC current implementation does the simplest thing that I can still reason about - it chooses first live node in alphabetical order.

michaelklishin commented 7 years ago

@binarin thanks, I will edit out that line now.