rabbitmq / rabbitmq-cli

Command line tools for RabbitMQ
Other
105 stars 34 forks source link

wait_command.ex: Change `wait` internal sleep to one second #400

Closed dumbbell closed 4 years ago

dumbbell commented 4 years ago

... down from 10% of the configured timeout.

This has a significant impact on the time it takes to start RabbitMQ in all our testsuites. rabbitmq-ct-helpers sets a wait timeout of 180 seconds. Thus before this patch, the wait loop would sleep for 18 seconds between each check. Given it takes about 1.5 seconds to start RabbitMQ, a lot of time is wasted here.

Here are some numbers after running testsuites with and without this patch:

michaelklishin commented 4 years ago

This is a great find.