search

rabbitmq / rabbitmq-common

Common library used by rabbitmq-server and rabbitmq-erlang-client
Other
66 stars 112 forks source link

rabbitmq-run.mk: Fix stop-brokers with NODES > 1 #281

Closed jeckersb closed 5 years ago

jeckersb commented 5 years ago

Remove extra "1" in seq command. Previously, as an example with NODES=2, will run seq 2 1 which produces no items to iterate, so the entire stop-node loop does not execute and the brokers are left running.

(This should qualify as an Obvious Fix for CLA purposes)

pivotal-issuemaster commented 5 years ago

@jeckersb Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented 5 years ago

@jeckersb This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.

michaelklishin commented 5 years ago

Thank you. We will take a look at this after our team-wide getaway that's happening this week.

jeckersb commented 5 years ago

@dumbbell thanks, makes much more sense to stop them in reverse order :)

dumbbell commented 5 years ago

Thank you, I merged your patch.

That was my mistake. I only tested this on my workstation running FreeBSD and seq(1) on BSD doesn't have the same default behavior regarding the implicit increment as the GNU implementation. So the usual Works On My Machine™ :-)