rabbit_backing_queue: extend is_duplicate callback return values

rabbitmq / rabbitmq-common

Common library used by rabbitmq-server and rabbitmq-erlang-client

Other

66 stars 112 forks source link

Closed noxdafox closed 5 years ago

noxdafox commented 5 years ago

Allow the backing queue implementation to instruct the amqqueue process on how to proceed when a message duplicate is encountered.

{true, drop} the message is a duplicate and should be ignored
{true, reject} the message is a duplicate and the publisher should receive a rejection
false the message is not deemed a duplicate
true kept for backward compatibility, equivalent to {true, drop}

Signed-off-by: Matteo Cafasso noxdafox@gmail.com

pivotal-issuemaster commented 5 years ago

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

noxdafox commented 5 years ago

This based on the discussions on rabbitmq-server #1741

pivotal-issuemaster commented 5 years ago

@noxdafox Thank you for signing the Contributor License Agreement!

michaelklishin commented 5 years ago

Thank you, I like how simple this might end up being. We will do the same due diligence as in #1741 next week :)