rabbit_misc: Generate a `NEW_PID_EXT`-based binary in compose_pid/4

rabbitmq / rabbitmq-common

Common library used by rabbitmq-server and rabbitmq-erlang-client

Other

66 stars 112 forks source link

rabbit_misc: Generate a `NEW_PID_EXT`-based binary in compose_pid/4 #321

Closed dumbbell closed 5 years ago

dumbbell commented 5 years ago

The creation field might not fit into one byte which makes the PID_EXT format unsuitable for this case.

The NEW_PID_EXT format is supported since Erlang 19.0, so it is safe to always use it, no matter the value of creation, because modern RabbitMQ 3.7+ versions require at least Erlang 20.3+.

References #313.

dumbbell commented 5 years ago

Thank you!

michaelklishin commented 5 years ago

Backported to v3.7.x.