Use "hostname -s" on non-msys2 platforms

rabbitmq / rabbitmq-common

Common library used by rabbitmq-server and rabbitmq-erlang-client

Other

66 stars 112 forks source link

Use "hostname -s" on non-msys2 platforms #375

Closed lukebakken closed 4 years ago

lukebakken commented 4 years ago

Fixes #374

Tested on FreeBSD 12 and Debian Buster. Ran run-broker and start-cluster on each, worked as expected.

On Windows using msys2, run-broker works. start-cluster needs work, but not related to this.

lukebakken commented 4 years ago

@dumbbell re-tested on msys2, FreeBSD 12 and Debian Buster

lukebakken commented 4 years ago

@dumbbell already addressed in this commit - https://github.com/rabbitmq/rabbitmq-common/pull/375/commits/a3c785507b6dbc7498235c6ef1f564ae75bc25fe

Maybe you need to refresh?

dumbbell commented 4 years ago

Sorry, when I first submitted the review, I forgot to change the state. When I wanted to resubmit, GitHub required me to add a comment, and yes, I didn't see you already addressed the comment.

You didn't miss anything :)

lukebakken commented 4 years ago

Thanks @dumbbell