search

rabbitmq / rabbitmq-common

Common library used by rabbitmq-server and rabbitmq-erlang-client
Other
66 stars 112 forks source link

Update the supervisor2 module to use recent OTP as a base #411

Closed lukebakken closed 4 years ago

lukebakken commented 4 years ago

I recommend reviewing while ignoring white space:

https://github.com/rabbitmq/rabbitmq-common/pull/411/files?w=1

Fixes https://github.com/rabbitmq/rabbitmq-mqtt/issues/240

lukebakken commented 4 years ago

I still get some errors when running the entire rabbitmq-server CT tests (like connection tracking in the vhost suite) but I think they are unrelated to these changes.

michaelklishin commented 4 years ago 
gmake ct-per_user_connection_channel_limit; gmake ct-per_vhost_connection_limit

fails on this branch but not with master.

lukebakken commented 4 years ago

@michaelklishin somehow I missed that you had reviewed this. I'll look into it.

lukebakken commented 4 years ago

Argh yep something is up with the intrinsic supervisor type.

lukebakken commented 4 years ago

@michaelklishin turns out the fix for that is simple. I'm just reducing some log spam at the moment, and will add a test for the intrinsic type.

lukebakken commented 4 years ago

@michaelklishin thanks again for double-checking. Ready for another review.

Also see the test added for the intrinsic type here: https://github.com/rabbitmq/rabbitmq-server/pull/2457

michaelklishin commented 4 years ago

Let's wait for a week or two before backporting.

michaelklishin commented 4 years ago

Follow-up changes: a6bcdae2bb176a32edd35d5fbe2480e82497ccbc (cannot be cherry-picked, some changes are unrelated, so has to be applied manually).